fix: prevent duplicate artifact assignment #1245
Merged
+63
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Prevent duplicate artifact assignment, extracted some duplicate logic.
Closes #1242
How did you implement it:
Some minor refactoring so that code paths are not called twice redundantly (see issue #1242)
Old Coverage:
New Coverage:
How can we verify it:
sls package --verbose
with individual packaging switched on.I have tested this in my local project and it works for me.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO