Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compat): function level entry override #1226

Merged
merged 2 commits into from
Aug 27, 2022
Merged

fix(compat): function level entry override #1226

merged 2 commits into from
Aug 27, 2022

Conversation

vicary
Copy link
Member

@vicary vicary commented Aug 25, 2022 •
edited
Loading

Fixes #1225

@vicary vicary force-pushed the fix/1225-defineFunctionProperties branch 2 times, most recently from ecf55f5 to d3f17b4 Compare August 25, 2022 07:36
@vicary vicary mentioned this pull request Aug 25, 2022
Closed
@vicary vicary force-pushed the fix/1225-defineFunctionProperties branch 2 times, most recently from e23a8a3 to 14cc820 Compare August 26, 2022 14:54
@vicary vicary force-pushed the fix/1225-defineFunctionProperties branch from 14cc820 to 2b83ccc Compare August 26, 2022 14:55
@vicary vicary self-assigned this Aug 26, 2022
@vicary vicary marked this pull request as ready for review August 26, 2022 14:57
j0k3r
j0k3r approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chances to find a better title? :)

@j0k3r j0k3r added this to the 5.9.1 milestone Aug 26, 2022
@vicary vicary changed the title fix: #1225 defineFunctionProperties fix(compat): function level entry override Aug 26, 2022
@vicary
Copy link
Member Author

vicary commented Aug 26, 2022

This is the best one I can come up with, feel free to edit if you got a better one!

@vicary vicary merged commit 64dc865 into master Aug 27, 2022
@vicary vicary deleted the fix/1225-defineFunctionProperties branch August 27, 2022 17:57
@vicary vicary mentioned this pull request Aug 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r approved these changes

@miguel-a-calles-mba miguel-a-calles-mba Awaiting requested review from miguel-a-calles-mba

Assignees

@vicary vicary

Labels
None yet
Projects
None yet
Milestone
5.9.1
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'defineFunctionProperties' of undefined
2 participants
@vicary @j0k3r