Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type of --webpack-use-polling option #1213

Merged

Conversation

emiksk
Copy link
Contributor

@emiksk emiksk commented Jul 29, 2022

What did you implement:

I added the type field of --webpack-use-polling option because the option causes the CLI_OPTIONS_SCHEMA_V3 deprecation.
https://www.serverless.com/framework/docs/deprecations/#cli-options-extensions-type-requirement

A result of serverless doctor is the following in the current version.

CLI options definitions were upgraded with "type" property (which could be one of "string", "boolean", "multiple"). Below listed plugins do not predefine type for introduced options:
 - ServerlessWebpack for "webpack-use-polling"
Please report this issue in plugin issue tracker.
Starting with next major release, this will be communicated with a thrown error.
More info: https://serverless.com/framework/docs/deprecations/#CLI_OPTIONS_SCHEMA_V3

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: YES

Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@j0k3r j0k3r merged commit d376a44 into serverless-heaven:master Jul 29, 2022
@emiksk emiksk deleted the add-type-of-webpack-use-polling branch July 29, 2022 05:25
@j0k3r j0k3r added this to the 5.9.0 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants