Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Prevent includeModules and noInstall at the same time. #1023

Merged
merged 3 commits into from
Dec 10, 2021
Merged

bug: Prevent includeModules and noInstall at the same time. #1023

merged 3 commits into from
Dec 10, 2021

Conversation

vicary
Copy link
Member

@vicary vicary commented Dec 10, 2021 •
edited
Loading

Temporarily patches #1012.

@vicary vicary requested a review from j0k3r December 10, 2021 07:30
j0k3r
j0k3r approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean #1012?

@vicary
Copy link
Member Author

vicary commented Dec 10, 2021

Oh sorry for my typo, yes it is!

@j0k3r j0k3r merged commit ed117a7 into master Dec 10, 2021
@j0k3r j0k3r deleted the 1012-configuration-include-modules-no-install branch December 10, 2021 08:38
@j0k3r j0k3r added this to the 5.7.0 milestone Dec 10, 2021
@j0k3r j0k3r modified the milestones: 5.7.0, 5.6.1 Jan 26, 2022
@j0k3r j0k3r mentioned this pull request Jan 26, 2022
Merged
@mokone91 mokone91 mentioned this pull request Sep 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r approved these changes

@miguel-a-calles-mba miguel-a-calles-mba Awaiting requested review from miguel-a-calles-mba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@vicary @j0k3r