Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): add noBuild option #1007

Merged
merged 2 commits into from
Nov 19, 2021
Merged

feat(compiler): add noBuild option #1007

merged 2 commits into from
Nov 19, 2021

Conversation

vicary
Copy link
Member

@vicary vicary commented Nov 19, 2021

What did you implement:

Closes #965

I removed the --no-build CLI option from README to discourage usage, the actual feature is kept for backward compatibility.

How did you implement it:

custom:
  webpack:
    noBuild: true

How can we verify it:

> serverless deploy
> serverless invoke local
> serverless offline

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@vicary vicary requested a review from j0k3r November 19, 2021 18:12
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@j0k3r j0k3r added this to the 5.6.0 milestone Nov 19, 2021
@vicary vicary merged commit 44dc73e into master Nov 19, 2021
@vicary vicary deleted the no-build-yml branch November 19, 2021 19:01
@j0k3r j0k3r mentioned this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local invoke with --no-build flag(s) causes deprecation warnings
2 participants