Fix command resolution when watch is involved #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
changed the title
j0k3r
reviewed
Nov 19, 2021
medikoo
force-pushed
the
1119-fix-processing-resolution
branch
from
179d24f to
19712f1
Compare
Sure, rebased |
j0k3r
approved these changes
Nov 19, 2021
vicary
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Never successfully setup the --watch option either, whenever I tried serverless invoke local --watch it always fails to run upon code change.
Despite the error above, a quick check with serverless@^3.0.0-pre proves this change indeed prevents a crash.
I am happy to take this at its current state, in fact any improvements are welcomed.
|
@medikoo could again rebase against the master? Thanks |
medikoo
force-pushed
the
1119-fix-processing-resolution
branch
from
19712f1 to
37d9e0f
Compare
|
Sure, pushed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the plugin with the Serverless Framework, I've discovered that the plugin finalizes the given processing hook (and in turn command) while leaving some command-specific logic working in the background.
Such configuration introduces some erroneous side effects. Framework assumes that command was finalized and pursues some cleanup operations. Command seems to operate without issues only because Framework doesn't imply a hard exit on the process.
It's especially important to have it fixed before v3 of the Framework is released, as it comes with new logging interfaces, and e.g. on command finalization, all progress bars are permanently cleared, leaving this feature no further operable (while it's a valuable feature for watching as configured in this plugin)