Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excludeRegex not excluding files #776

Closed
l1b3r opened this issue Apr 8, 2021 · 1 comment · Fixed by #780
Closed

excludeRegex not excluding files #776

l1b3r opened this issue Apr 8, 2021 · 1 comment · Fixed by #780
Milestone

Comments

@l1b3r
Copy link

l1b3r commented Apr 8, 2021

This is a (Bug Report / Feature Proposal)

Description

For bug reports:

  • What went wrong?
    When running sls package --verbose, excludeRegex option added in v5.4.0 seems to be ignoring the regex and still adds all files to the output zip files.

  • What did you expect should have happened?
    Files that match excludeRegex should be excluded from the packaged zip files.

  • What was the config you used?

webpack: {
            keepOutputDirectory: true,
            excludeRegex: /\.ts|test|\.map/
        }

(I'm using serverless.ts instead of serverless.yml but that shouldn't matter I believe)

  • What stacktrace or error message from your provider did you see?
    sls package --verbose does not throw any explicit errors.

For feature proposals:

  • What is the use case that should be solved. The more detail you describe this in the easier it is to understand for us.
  • If there is additional config how would it look

Similar or dependent issue(s):

Additional Data

  • Serverless-Webpack Version you're using: 5.4.1
  • Webpack version you're using: 5.6.0
  • Serverless Framework Version you're using: 2.10.0
  • Operating System: Windows 10
  • Stack Trace (if available):
@chaoyangnz
Copy link

not working, just debug into packageModules.js where files in filters, but not passed into the zip args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants