Fix excludeRegex option and allow dotfiles to be packaged
#780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
LGTM, looking forward for this to go live. This little yet useful feature can alleviate quite some amount of custom wizardry in Webpack config to make sure e.g. source maps don't end up bundled into the deploy packages 👍 |
Also: - dump a message to log how files were excluded (might be good for debugging) - update unit test to actually match the type of `excludeRegex` from the configuration (which is not a regex but a string)
j0k3r
force-pushed
the
fix/exclude-regex
branch
from
75196f4 to
50b9510
Compare
|
Whoops. I missed the email notifications. Sorry about that, @j0k3r. |
miguel-a-calles-mba
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersed #777 (thanks @l1b3r!)
Fix #776
Fix #744
Most improvement on how exclude regex is working.
A message will now be logged in verbose mode so the user will know how many files were excluded (if any). It'll be easier to debug.
The zip command now receive a list of files to zip. It'll solve the dotfiles problem because we were using
*as pattern to find files but this pattern does not include dotfiles by default (see #744).