Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asynchronous configuration object support for Webpack #412

Closed
nidin opened this issue Jun 20, 2018 · 0 comments · Fixed by #413
Closed

Asynchronous configuration object support for Webpack #412

nidin opened this issue Jun 20, 2018 · 0 comments · Fixed by #413
Labels
feature
Milestone
5.2.0

Comments

@nidin
Copy link
Contributor

nidin commented Jun 20, 2018

This is a Feature Proposal

Description

Webpack 2+ support async configuration object by exporting a promise as configuration object.
This is a feature request to support async configuration object. This feature helps to define env variables and constants inside code after an async operation inside webpack.config.js. for example defining AccountId of current user inside lambda@edge which does not support defining normal process environment variables.

Similar or dependent issue(s):

Additional Data

  • Serverless-Webpack Version: 5.1.5
  • Webpack version: 4.11.1
  • Serverless Framework Version: 1.27.2
  • Operating System: MacOS High Sierra (10.13.5)
  • Stack Trace:
nidin added a commit to nidin/serverless-webpack that referenced this issue Jun 20, 2018
@nidin
Added support for async webpack config object
32fbab4 
Webpack 2+ support async configuration object by exporting a promise as configuration object.
This PR added support for async configuration object.
Closes serverless-heaven#412
@nidin nidin mentioned this issue Jun 20, 2018
Merged
7 tasks
@HyperBrain HyperBrain added this to the 5.2.0 milestone Jun 21, 2018
This was referenced Sep 23, 2018
Closed
Merged
Open
@renovate renovate bot mentioned this issue Oct 29, 2018
Merged
@renovate renovate bot mentioned this issue Nov 9, 2018
Merged
1 task
jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this issue Oct 15, 2019
@nidin
Added support for async webpack config object
d2ac37d 
Webpack 2+ support async configuration object by exporting a promise as configuration object.
This PR added support for async configuration object.
Closes serverless-heaven#412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Added support for async webpack config object nidin/serverless-webpack
2 participants
@nidin @HyperBrain