Added support to have an alias subscribe to an existing SNS topic #94 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 24, 2018 08:49
|
Hi @zachboyd , thanks for the contribution 💯 . I will review it as soon as possible. |
|
Thanks! I just fixed the lint issues and pushed changes as well. |
|
BTW: The project contains a proper |
|
Great! I went ahead and installed the plugin for any future work I am able to contribute back. |
|
Thanks @zachboyd, it's exactly what I was looking for and it works well! 👍 |
defnotrobbie
pushed a commit
to 1stdibs/serverless-aws-alias
that referenced
this pull request
Nov 14, 2022
…n-fix Added support to have an alias subscribe to an existing SNS topic serverless-heaven#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #94
This PR adds support for resources of type AWS::SNS::Subscription to be transferred to the alias stack. This resource will be present in the cloudformation template when a lambda subscribes to an existing SNS topic by ARN.