Fixed detection of Principal for Serverless 1.27 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defnotrobbie
pushed a commit
to 1stdibs/serverless-aws-alias
that referenced
this pull request
Nov 14, 2022
…rless-1-27 Fixed detection of Principal for Serverless 1.27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Serverless 1.27 changed the construction of the Principal propertiy in permission resources from a string to a
Fn::Join. This breaks the principal detection that sorts the permissions by services for the alias stack.I extended the principal validation to adhere to these changes. All permission objects (APIG, CWEvents and SNS) should now be attached to the correct function aliases again.
To verify the fix, check if the permissions show up in the AWS Lambda console and are attached only to the aliases, not to
$LATEST.