Propagate video.play() NotSupportedError
#259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank-you for your Patch! We have forked the project and are accepting Pull Requests here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
NotSupportedErrorsometimes gets thrown and in debugging why I noticed that Quagga is causing an unhandled rejection error here because it doesn't catch and propagate theNotSupportedErrorwhenvideo.play()is called on a video element that doesn't have a supported source (the cause of thatNotSupportedErroris completely unrelated to this PR).This is a small PR that fixes that, and wraps the
reject('Unable to play video stream. Is webcam working?')near the top of the file in an error object so it works better with our application logging and gives us a full stack-trace when it happens.