[Chore] v18.0-rc1 hotfixes #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The reason of nix build failure was the dependency of time-measurement library, which doesn't seem to be required at all for the octez binaries build. Solution: Remove previous hack and exclude `tezos-time-measurement` opam file.
Problem: Release number was not reset on new upstream release. Solution: Reset it.
Problem: Previously, we took all opam files found in the repo, installing dependencies of it. But it is redundant, since all deps are concentrated in one opam file. Solution: Install deps using `octez-deps.opam`.
pasqu4le
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Native packages binary build seem to be broken too, the same reason as the nix build's one.
The reason is we recursively search for
opamfiles in thetezosrepo and try to use them all. We excludeoctez-dev-deps.opam, but one more file now should be excluded for the correct build.Regarding native builds, there is no need to search all opam files recursively at all. All deps are located in one opam file. Commands for binary build are taken from the
tezosMakefile scripts.Related issue(s)
Resolves #
Related changes (conditional)
I checked whether I should update the README
I checked whether native packaging works, i.e. native binary packages
can be successfully built.
Stylistic guide (mandatory)