Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cabal files to resolve build issues with stack>=2.1.* #9

Merged
merged 1 commit into from
May 27, 2020

Conversation

flyingleafe
Copy link
Contributor

✅ Checklist for your Pull Request

It is a known fact that Stack, starting from versions 2.1.*, cannot into imported hpack configuration files for Git-fetched extra deps: commercialhaskell/stack#4906

Even better, this issue is a wontfix, so Stack is not even expected to support this anymore in later versions.

As servant-util is widely used throughout Serokell projects, mostly as a git-fetched extra dep, this prevents newer stack versions to be able to build lots of Serokell projects.

We can resolve this just by using older versions of stack throughout the company, but frankly it is better to just include .cabal files in this repo.

@flyingleafe flyingleafe requested a review from Martoon-00 May 26, 2020 21:18
Copy link
Member

@Martoon-00 Martoon-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's do it. Thanks for keeping this library updated!

@flyingleafe flyingleafe merged commit 8e9cdb8 into master May 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the flyingleafe/add-cabal-files branch May 27, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants