Skip to content
This repository has been archived by the owner on May 25, 2020. It is now read-only.

fix: don't double escape special characters in title #795

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: don't double escape special characters in title #795

wants to merge 3 commits into from

Conversation

inyono
Copy link
Member

@inyono inyono commented Nov 13, 2018 •
edited
Loading

Changelog

Fixed

  • Don't double escape special characters (e.g. <, *) in entities' title (#795)

@inyono inyono requested a review from Knorrke November 13, 2018 16:29
@inyono
Merge branch 'development' of github.com:serlo-org/athene2 into featu…
be1d58a 
…re/input-filter

# Conflicts:
#	src/module/Ui/templates/entity/page/applet.twig
#	src/module/Ui/templates/entity/page/article.twig
#	src/module/Ui/templates/entity/page/course-page.twig
#	src/module/Ui/templates/entity/page/course.twig
#	src/module/Ui/templates/taxonomy/term/entity/article.twig
@Knorrke
Copy link
Member

Knorrke commented Nov 13, 2018

Can you check the notification and event templates again? I couldn't create the notifications locally, but at least I could inject a <script> in the reasoning when accepting/rejecting a revision... This script was then executed e.g. in /event/history and also in the user profile (and probably also in a notification?)

@Knorrke Knorrke mentioned this pull request Nov 14, 2018
Merged
@inyono inyono changed the base branch from development to master January 22, 2019 18:53
@inyono inyono mentioned this pull request Jun 24, 2019
Closed
@kulla kulla mentioned this pull request Feb 19, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Knorrke Knorrke Awaiting requested review from Knorrke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inyono @Knorrke