-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 8 RTM and Serilog 3.1.1 #401
Conversation
Working my way through the 8.0.0 releases; this is pretty low in the dependency graph so pushing this through :-) |
If anyone has a chance to check out the build/test failures - I'm not very familiar with how TestApp is set up/used, it'd be great to have some more eyes on it :-) |
I'll look into it. |
Think I have it sorted - thanks @0xced! |
Build.ps1 was using a direct .dll invocation to kick off tests, something in that mode prevents |
@@ -1,5 +1,5 @@ | |||
{ | |||
"sdk": { | |||
"version": "8.0.100-rc.2.23502.2" | |||
"version": "8.0.100" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably restore "rollForward": "latestFeature"
(and maybe "allowPrerelease": false
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, will do on the next round if you don't beat me to it :-) 👍
No description provided.