Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build script #378

Merged
merged 1 commit into from
May 9, 2023
Merged

Fix build script #378

merged 1 commit into from
May 9, 2023

Conversation

0xced
Copy link
Member

@0xced 0xced commented May 5, 2023

Use throw to exit when a dotnet command fails so that errors are properly reported on AppVeyor.

See also #372

Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@0xced
Copy link
Member Author

0xced commented May 8, 2023

It seems to work!

This is what happened with build 46983236 that failed before #380 was merged:

AppVeyor build 46983236 failure

Use `throw` to exit when a `dotnet` command fails so that errors are properly reported on AppVeyor.

See also serilog#372
@0xced 0xced force-pushed the fix-build-script branch from 4e70997 to 1e370b5 Compare May 8, 2023 16:13
@nblumhardt nblumhardt merged commit 0793eba into serilog:dev May 9, 2023
@0xced 0xced deleted the fix-build-script branch May 9, 2023 09:22
@nblumhardt nblumhardt mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants