Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReSharper/Rider inspection warnings #312

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

0xced
Copy link
Member

@0xced 0xced commented May 10, 2022

The serilog-settings-configuration.sln.DotSettings file defines many custom inspection severities as error rendering the solution with many red squiggly lines when opened in Rider or in Visual Studio with ReSharper.

@nblumhardt
Copy link
Member

Thanks for all of this @0xced ! 👍 👍

Looks like a test failure:

Failed Serilog.Settings.Configuration.Tests.DllScanningAssemblyFinderTests.ShouldProbeCurrentDirectory [5 ms]
  Error Message:
   System.IO.DirectoryNotFoundException : Could not find a part of the path 'C:\projects\serilog-settings-configuration\test\Serilog.Settings.Configuration.Tests\bin\Release\net50\bin1'.
  Stack Trace:
     at System.IO.FileSystem.GetFindData(String fullPath, WIN32_FIND_DATA& findData)
   at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive)
   at System.IO.Directory.Delete(String path, Boolean recursive)
   at Serilog.Settings.Configuration.Tests.DllScanningAssemblyFinderTests.Dispose() in C:\projects\serilog-settings-configuration\test\Serilog.Settings.Configuration.Tests\DllScanningAssemblyFinderTests.cs:line 18
   at ReflectionAbstractionExtensions.DisposeTestClass(ITest test, Object testClass, IMessageBus messageBus, ExecutionTimer timer, CancellationTokenSource cancellationTokenSource)
Failed!  - Failed:     1, Passed:   116, Skipped:     0, Total:   117, Duration: 592 ms -

@0xced
Copy link
Member Author

0xced commented May 11, 2022

Oops. I fixed the issue, rebased on the dev branch and force pushed. Everything is ✅ now.

The `serilog-settings-configuration.sln.DotSettings` file defines many custom inspection severities as error rendering the solution with many red squiggly lines when opened in Rider or in Visual Studio with ReSharper.
@skomis-mm skomis-mm merged commit e02d19e into serilog:dev May 11, 2022
@skomis-mm
Copy link
Contributor

Thanks, @0xced 👍

@0xced 0xced deleted the fix-warnings branch May 11, 2022 14:36
@nblumhardt nblumhardt mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants