Add .NET 6 to other target frameworks, add conditions based on TFM for Nuget packages. #57
Conversation
|
Thanks for the PR! 😎 AppVeyor worker will need to be the VS 2022 one in order to use the 6.0 SDK (see appveyor.yml). |
You are most welcome.🌹 |
| <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="3.1.22" /> | ||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="3.1.22" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="3.1.22" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Just a note for the next pass through - we've done this in other packages previously and IIRC it made life difficult in some situations. I'll need to go back over our old threads/tickets/PRs and review how it was that we landed on the current approach.
src/Serilog.Extensions.Hosting/Serilog.Extensions.Hosting.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan Maximov <[email protected]>
|
Thank you again for pushing this forwards @ArminShoeibi, sorry I somewhat dropped the ball at this end :-) #71 now finally resolves this, in a way that we can make consistent across all the various Microsoft.Extensions.*-related Serilog packages. |
That's great, happy to see version 7 of dependencies 😁 |
Hello dear Nicholas.
This pull request adds .NET6 to other TFMs and use conditions for installing dependencies.
I Bumped TFM of sample projects to .NET 6.
Everything is okay.