Make DiagnosticContextCollector thread-safe #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at this again, it would be too easy to violate the single-threadedness of
DiagnosticContextCollector
in the current design - there's no indication in the API ofIDiagnosticContext
that there are any constraints on how its called.This PR introduces a simple mutex to make
DiagnosticContextCollector
thread-safe. There's a possibility this could be done lock-free, but that's probably fine to punt for a future iteration.After the PR, the example in #9 (comment) will be correct/safe: