Use Microsoft.Data.SqlClient for all platforms except net452 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… platforms except net452. using statements wrapped with preprocessor if to pull in appropriate namespace.
|
Nice work @mungk! Thank you very much for the contribution! |
|
Note for anyone else Googling for: Upgrading to this version fixes the issue if you're using the newer connection string attribute names, described further here (dotnet/SqlClient#811) as this PR means Thanks for this ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced System.Data.SqlClient with Microsoft.Data.SqlClient for all platforms except net452 (Microsoft.Data.SqlClient does not support net452).
Only the references and the namespaces needed to be changed in order to accommodate this. However, in order to support both packages in the same code base (again, due to net452), I had to add #if directives around the using statements to use the correct SqlClient library.
Resolves #208