New interfaces and support for Azure Managed Identities #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ckadluba
commented
Apr 20, 2020
ckadluba
commented
- Added new overloads for all config extension methods and sink contructors using SinkOptions class (old methods still work but will likely be deprecated in the future).
- Added support for Azure Managed Identities authentication (thanks to @darrenschwarz for sending us PR Adding support for MSI (Managed Service Identities), and AccessTokens… #222).
… used on supported target platforms (net472, netcoreapp2.2) to perform Azure managed identities token gathering. * Added AzureManagedServiceAuthenticator stub implementation which does nothing for target frameworks not supporting this * Added unit tests * Use AzureManagedServiceAuthenticator in SqlConnectionFactory to set token on connection * Initialization in the sink and audit siink classes still set the azure msi auth to disabled. It will be activated according to passed parameters in the next commits.
… to do) and to sink and audit sink contructors. * Sink and audit sink configure sql authentication accoding to values in sinkOptions parameter.
….Configuration * Adapted WorkerServiceDemo to use the new azure configuration values for sink and audit sink.
… instead of separate paramters. This works now when read from M.E.C. config in WorkerServiceDemo sample app and only for non-audit sink at this point.
… and ctor). * Implemented reading SinkOptions for config systems Microsoft.Extensions.Configuration and System.Configuration. * Added some basic integration tests for reading SinkOptions from config.
… based-interface wherever reasonable.
* Fixed: TimeSpan parsing for System.Configuration SinkOptionsProvider plus tests
* Renamed file AzureManagedServiceAuthenticator.Stub.cs to match unit test class file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.