Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basic Authentication Support to serilog-ui #97

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

traien
Copy link
Contributor

@traien traien commented Oct 31, 2023

This pull request enhances the serilog-ui project by adding support for basic authentication, allowing users to secure their log viewer with a username and password. This feature is valuable for controlling access to the log viewer, ensuring that only authorized personnel can view and analyze logs.

Changes Made:

  • Introduced a BasicAuthenticationFilter that can be configured to provide basic authentication for serilog-ui.

Usage:

To enable basic authentication for serilog-ui, developers can now use the BasicAuthenticationFilter by configuring it in their Startup.Configure method, as described in the README.

Testing:

Testing has been performed to verify the proper functioning of the basic authentication feature.

@mo-esmp
Copy link
Member

mo-esmp commented Nov 1, 2023

@traien Thanks for the PR.
@followynne Do you think we can provide inputs in the UI (like JWT) to enter username and password instead of hardcoding in the code?

@mo-esmp
Copy link
Member

mo-esmp commented Nov 6, 2023

@traien going to review and merge your PR tonight. Later, we will add UI for it

@followynne
Copy link
Member

Hello @mo-esmp @traien

Sorry I don't have time to test the PR those days 😔
From a quick look it seems all good, my only suggestion / request would be to remove any README modification but put those in the correct wiki page (those wiki contribs are well accepted, thanks a lot for having written them!) 🙂

For the ui part, I agree on having them settable from there - noted down this change for the new one, it will be included 😁

@mo-esmp mo-esmp requested a review from followynne November 6, 2023 22:11
@mo-esmp mo-esmp merged commit f6c2e28 into serilog-contrib:master Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants