-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 #114
V3 #114
Conversation
I'm attempting to test the 3.x alpha versions in my project that currently uses v2, but I'm running into issues building where it looks like the
I am using the net6.0 version if that matters. Any ideas what's going on here? |
Hey @tterrag1098 Thanks a lot for testing! I checked those packages and they target from NET6 onwards, thus they should be fine. If you comment any serilog-ui setup code, does the project compile or it still fails to restore the dlls? (EDIT: another guess that came to my mind is about mismatching versions of the same assembly, you could check if those two dlls are included from other packages) EDIT2: (on a similar topic, not sure if it could help: dotnet/runtime#93780) Can I ask you, when you have time, to try the following:
I want to understand if it happens on the samples/clean projects or if it is an issue with migrating the project (or the nuget local cache)... |
@tterrag1098: a small update, I tried running the repository sample and a new clean project targeting NET6 and they both worked. Can you kindly let me know if the issue still occurs and add any additional detail on which provider are you using? |
I'm not sure what you're referring to by "provider", but it's a VS solution with quite a few dependencies. However I've looked through the entire manifest and nothing directly refers to these versions of Json/DI. Can you use ildasm on the dlls you have and see if these extern entries exist there too? |
This is the specific error I get from CSC:
|
In Serilog.UI, there's the Web package and you load data using one of the provided providers packages (Mongo, SqlServer etc). From Ildasm, I have your same situation:
From the provided error, I think you're looking in the wrong direction using ildasm - I'd suggest the following:
Eventually, you should check yours .csproj for anything unexpected that could have been added automatically by an IDE. If you don't solve the issue, can you provide me a NET6 sample project where you reproduce the issue? Without it, I won't be able to help you further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @followynne and so sorry for the late review. You can consider my comments optional and ignore them. Later, we will discuss some matters and improve the project. Please update nuget packages to the latest version and comment codes inside code_quality.yml
file.
Hi @mo-esmp sorry for the late answer, had some busy weeks and didn't find the time to check earlier 😿 I'll review them in those days and comment on any conversation, if I have doubts 😄 Then I'll give a check to issue #122, before merging the work. About the SQL Lite PR, I'll do a review after we merge v3, to release it as a new provider from v3 onwards ;) (ps just as an info, I have no rights to release RavenDB package, in case I'll ask you help 👍 ) |
UI v3!
What to expect in the new UI:
What to expect in the Backend:
Breaking changes
IHttpContextAccessor
interfaceNew features - BE
Sort option
The user can now sort the search by: timestamp | message | level
with direction ASC | DESC
Known limitation: ElasticSearch provider has a fixed sort by timestamp, due to the sink indexes limitation.
Authorization filters
Registration is now managed by DI; there are some new extensions method that take a T implementation of filter and register it as scoped [example: src/Serilog.Ui.Core/Extensions/SerilogUiOptionsBuilderExtensions.cs].
Added a new AuthorizationFilter:
PolicyAuthorizationFilter
, that check authorization based on a registered policyMySql/MariaDB
Split provider registration in 2 extension methods, to better help user the end user choose the correct provider based on the used sink.
Refactor
Bugfix