Fix #104 - Support PostgreSQL alternative sink #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/serilog-contrib/serilog-ui into feature/support-postgresql-sink-alternative
followynne
requested changes
Jan 23, 2024
There was a problem hiding this comment.
I would move it inside Postgres...Provider/Models/ folder, just for clarity :)
There was a problem hiding this comment.
I would move it inside Postgres...Provider/Models/ folder, just for clarity :)
There was a problem hiding this comment.
As per previous comment, would move inside Postgres...Provider/Models
There was a problem hiding this comment.
as per previous comment, would move it inside Postgres...Provider/Models/
There was a problem hiding this comment.
as per previous comment, would move it inside Postgres...Provider/Models/
tests/Serilog.Ui.PostgreSqlProvider.Tests/DataProvider/DataProviderBaseTest.cs
Show resolved
Hide resolved
|
@followynne I applied your comments; please re-review. |
followynne
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix issue 104, to support Serilog.Sinks.Postgresql.Alternative sink.
Hence, existing integration tests are according to Serilog.Sinks.PostgresSQL, I added some unit tests (
QueryBuilderTests.cs) for query generation based on Serilog.Sinks.Postgresql.Alternative. Once we refactored integration tests and used sinks to insert log data, we could unify tests for both sinks.