Skip to content
This repository has been archived by the owner on Apr 18, 2022. It is now read-only.

Updated solution for using .NET 4.5 and Serilog 2.x #34

Merged
merged 3 commits into from
Feb 14, 2017

Conversation

ahydrax
Copy link
Contributor

@ahydrax ahydrax commented Feb 11, 2017

Hello there,

This package can be used now with Serilog 2.x versions.

@endofcake
Copy link
Contributor

This looks good to me.
@thirkcircus , ok to merge?

@JustinThirkell
Copy link
Contributor

@ahydrax , we originally had this targeting net40 due to a downstream consumer (that we also own).
is there a particular need to target net45? is that the min framework version supported by serilog 2x?

@ahydrax
Copy link
Contributor Author

ahydrax commented Feb 14, 2017

@thirkcircus , as I can see here it's a minimum required version.

@JustinThirkell JustinThirkell merged commit 02a2fe8 into serilog-archive:master Feb 14, 2017
@JustinThirkell
Copy link
Contributor

fair enough then. 😄
thanks!

@esukirno
Copy link

esukirno commented Sep 8, 2017

Hi @thirkcircus @ahydrax. I still cannot find nuget package for this sink with serilog 2.x.x dependency.
Did this PR build artifact get pushed to nuget.org?

@ahydrax
Copy link
Contributor Author

ahydrax commented Sep 9, 2017

@esukirno seems not. @thirkcircus do you have an access to nuget package management?

@JustinThirkell
Copy link
Contributor

Sorry, I don't.
It's been a long time since I looked at this project and I was thinking that I must have a build pipeline somewhere but I've just checked nuget.org and this package isn't listed under my name, so it can't have been me who pushed it. @nblumhardt might know about any build pipeline...

@nblumhardt
Copy link
Contributor

Hi folks,

Indeed it does! :-) .. The build pipeline's linked from the README: https://ci.appveyor.com/project/serilog/serilog-sinks-amazonkinesis/branch/master

The latest build completed with the following:

Collecting artifacts...
Found artifact 'Serilog.Sinks.AmazonKinesis.2.0.99.nupkg' matching 'Serilog.*.nupkg' path
Uploading artifacts...
[1/1] Serilog.Sinks.AmazonKinesis.2.0.99.nupkg (67,319 bytes)...100%
"NuGet" deployment has been skipped as environment variable has not matched ("appveyor_repo_tag" is "false", should be "true")
Build success

The YML build configuration exported from AppVeyor is:

version: '{build}'
build_script:
- ps: >-
    $version = $env:APPVEYOR_REPO_TAG_NAME

    if (-not $version) {

    $version = "2.0"

    }

    ./Build.ps1 -majorMinor "$version" -patch "$env:APPVEYOR_BUILD_VERSION" -customLogger "C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll"
artifacts:
- path: Serilog.*.nupkg
deploy:
- provider: NuGet
  api_key:
    secure: nvZ/z+pMS91b3kG4DgfES5AcmwwGoBYQxr9kp4XiJHj25SAlgdIxFx++1N0lFH2x
  on:
    branch: master
    appveyor_repo_tag: true

I'll remove the last line and check this into master - should get things unblocked. (Ideally we'e move the project to the new build scripts in line with the other Serilog sinks at some point.)

@nblumhardt
Copy link
Contributor

@ahydrax
Copy link
Contributor Author

ahydrax commented Sep 11, 2017

@nblumhardt thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants