Make sure fd is properly closed if initialization fails #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannic
changed the title
|
Looks good overall, thanks for this! It seems there is one instance of |
Oops, yes, sorry. Missed that one as it's cfg-gated on ios/macos. |
jessebraham
approved these changes
Mar 14, 2022
jannic
added a commit
to jannic/serialport-rs
that referenced
this pull request
Mar 18, 2022
If opening succeeded, automatic closing on drop must be skipped
jessebraham
pushed a commit
that referenced
this pull request
Mar 22, 2022
If opening succeeded, automatic closing on drop must be skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38