Remove the serial port factory and throw errors on invalid arguments #822

reconbot · 2016-05-24T04:24:12Z

Constructor now throws errors when given invalid options
The Constructor’s callback is given to .open() if openImmediately is set
Depreciation warning when using the old style SerialPort.SerialPort

Closes #820

gnarf · 2016-05-25T13:58:47Z

bin/serialport-terminal.js

@@ -49,7 +49,7 @@ var openOptions = {
  stopBits: args.stopbits
 };

-var port = new serialport.SerialPort(args.port, openOptions);
+var port = new Serialport(args.port, openOptions);


Just to mention, you might want to hunt for Serialport -> SerialPort for consistency

- Constructor now throws errors when given invalid options - The Constructor’s callback is given to `.open()` if `openImmediately` is set - Depreciation warning when using the old style SerialPort.SerialPort

reconbot · 2016-05-26T14:03:37Z

@gnarf thanks for the clever one time depreciation warning!

…822) - Constructor now throws errors when given invalid options - The Constructor’s callback is given to `.open()` if `openImmediately` is set - Depreciation warning when using the old style SerialPort.SerialPort

reconbot added the for-review label May 24, 2016

gnarf reviewed May 25, 2016
View reviewed changes

reconbot force-pushed the throw-errs branch from c645996 to e10c4e2 Compare May 26, 2016 13:59

Remove the serial port factory and throw errors on invalid arguments

e519164

- Constructor now throws errors when given invalid options - The Constructor’s callback is given to `.open()` if `openImmediately` is set - Depreciation warning when using the old style SerialPort.SerialPort

reconbot force-pushed the throw-errs branch from e10c4e2 to e519164 Compare May 26, 2016 14:00

reconbot merged commit 9a98ede into master May 26, 2016

reconbot deleted the throw-errs branch May 26, 2016 15:41

lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the serial port factory and throw errors on invalid arguments #822

Remove the serial port factory and throw errors on invalid arguments #822

reconbot commented May 24, 2016 •

edited

Loading

gnarf May 25, 2016

reconbot commented May 26, 2016

Remove the serial port factory and throw errors on invalid arguments #822

Remove the serial port factory and throw errors on invalid arguments #822

Conversation

reconbot commented May 24, 2016 • edited Loading

gnarf May 25, 2016

Choose a reason for hiding this comment

reconbot commented May 26, 2016

reconbot commented May 24, 2016 •

edited

Loading