Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup flow control options during port construction #819

Closed
reconbot opened this issue May 23, 2016 · 0 comments · Fixed by #821
Closed

Cleanup flow control options during port construction #819

reconbot opened this issue May 23, 2016 · 0 comments · Fixed by #821
Labels
feature-request Feature or Enhancement
Milestone
4.0

Comments

@reconbot
Copy link
Member

We have flags, an array, and a boolean to set the flow control flags on a port. Lets keep it just the flags.

This would be a breaking change for 4.0
@reconbot reconbot added backlog feature-request Feature or Enhancement labels May 23, 2016
@reconbot reconbot added this to the 4.0 milestone May 23, 2016
@reconbot reconbot mentioned this issue May 23, 2016
Closed
11 tasks
reconbot added a commit that referenced this issue May 24, 2016
@reconbot
Remove the extra flow control settings
8578a0b 
closes #819
@reconbot reconbot mentioned this issue May 24, 2016
Merged
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Feature or Enhancement
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Flowcontrol serialport/node-serialport
1 participant
@reconbot