Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the openImmediately flag to the port options. #809

Closed
reconbot opened this issue May 16, 2016 · 0 comments · Fixed by #830
Closed

Move the openImmediately flag to the port options. #809

reconbot opened this issue May 16, 2016 · 0 comments · Fixed by #830
Labels
good first issue
Milestone
4.0

Comments

@reconbot
Copy link
Member

Having this boolean in the constructor isn't nearly as clean as having it in the options. Lets move it to the options and keep it's default behavior to true. This would be a major api change so we should bundle it with a few other api changes.
@reconbot reconbot changed the title Move the openImmediately flag to the port options. Move the openImmediately flag to the port options. May 16, 2016
@reconbot reconbot mentioned this issue May 16, 2016
Closed
@reconbot reconbot added 0 - Backlog feature-request Feature or Enhancement labels May 16, 2016
@reconbot reconbot added this to the 4.0 milestone May 23, 2016
@reconbot reconbot added good first issue and removed feature-request Feature or Enhancement labels May 23, 2016
@reconbot reconbot mentioned this issue May 23, 2016
Closed
11 tasks
reconbot added a commit that referenced this issue May 28, 2016
@reconbot
Remove the openImmediatly flag in favor of the autoOpen option
e1fd6e9 
closes #809
@reconbot reconbot mentioned this issue May 28, 2016
Merged
reconbot added a commit that referenced this issue May 29, 2016
@reconbot
Remove the openImmediatly flag in favor of the autoOpen option
e19e49e 
closes #809
reconbot added a commit that referenced this issue May 29, 2016
@reconbot
Remove the openImmediatly flag in favor of the autoOpen option (#830)
77c4ea3 
closes #809
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
reconbot added a commit that referenced this issue Jul 24, 2018
@reconbot
Remove the openImmediatly flag in favor of the autoOpen option (#830)
d9d78c1 
closes #809
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Remove the openImmediatly flag in favor of the autoOpen option serialport/node-serialport
1 participant
@reconbot