Beta test [email protected] #688

reconbot · 2016-03-25T20:56:08Z

We need confirmation that [email protected] works on the following platforms

Ideally with node 0.10, 0.12, 4 and 5.

Changes include (full diff):

Windows 10 support
Cleanup around error callbacks
Fix race condition closing serial port causes segfault #686 crash on port closing
Fix Bugfix/file descriptor 0 #586 crash when your system uses a file descriptor of 0

The text was updated successfully, but these errors were encountered:

rwaldron · 2016-03-28T21:25:15Z

OSX:

installs successfully
connects, disconnects successfully
reading and writing successful

reconbot · 2016-03-29T03:20:13Z

@rwaldron we just published [email protected] mind using that tomorrow?

fivdi · 2016-03-30T10:49:47Z

Raspbian Jessie 2016-02-26:

Node.js v0.10.29, v4.4.1, v5.9.1

installs successfully
tested with the UART at /dev/ttyAMA0 so I'm unsure what connect and disconnect mean
reading and writing successful

Node.js v6.0.0-nightly20160307061ebb39c9

npm install [email protected] results in compile errors:

pi@raspberrypi:~/serialport $ npm install [email protected]
(node:7165) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.

> [email protected] install /home/pi/serialport/node_modules/serialport
> node-pre-gyp install --fallback-to-build

make: Entering directory '/home/pi/serialport/node_modules/serialport/build'
  CXX(target) Release/obj.target/serialport/src/serialport.o
In file included from ../src/serialport.h:5:0,
                 from ../src/serialport.cpp:3:
../../nan/nan.h:590:20: error: variable or field ‘AddGCEpilogueCallback’ declared void
       v8::Isolate::GCEpilogueCallback callback
                    ^
../../nan/nan.h:590:7: error: ‘GCEpilogueCallback’ is not a member of ‘v8::Isolate’
       v8::Isolate::GCEpilogueCallback callback
       ^
../../nan/nan.h:591:18: error: expected primary-expression before ‘gc_type_filter’
     , v8::GCType gc_type_filter = v8::kGCTypeAll) {
                  ^
../../nan/nan.h:596:20: error: variable or field ‘RemoveGCEpilogueCallback’ declared void
       v8::Isolate::GCEpilogueCallback callback) {
                    ^
../../nan/nan.h:596:7: error: ‘GCEpilogueCallback’ is not a member of ‘v8::Isolate’
       v8::Isolate::GCEpilogueCallback callback) {
       ^
../../nan/nan.h:601:20: error: variable or field ‘AddGCPrologueCallback’ declared void
       v8::Isolate::GCPrologueCallback callback
                    ^
../../nan/nan.h:601:7: error: ‘GCPrologueCallback’ is not a member of ‘v8::Isolate’
       v8::Isolate::GCPrologueCallback callback
       ^
../../nan/nan.h:602:18: error: expected primary-expression before ‘gc_type_filter’
     , v8::GCType gc_type_filter = v8::kGCTypeAll) {
                  ^
../../nan/nan.h:607:20: error: variable or field ‘RemoveGCPrologueCallback’ declared void
       v8::Isolate::GCPrologueCallback callback) {
                    ^
../../nan/nan.h:607:7: error: ‘GCPrologueCallback’ is not a member of ‘v8::Isolate’
       v8::Isolate::GCPrologueCallback callback) {
       ^
serialport.target.mk:90: recipe for target 'Release/obj.target/serialport/src/serialport.o' failed
make: *** [Release/obj.target/serialport/src/serialport.o] Error 1
make: Leaving directory '/home/pi/serialport/node_modules/serialport/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:101:13)
gyp ERR! stack     at ChildProcess.emit (events.js:186:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)
gyp ERR! System Linux 4.1.18-v7+
gyp ERR! command "/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/node" "/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm/serialport.node" "--module_name=serialport" "--module_path=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm"
gyp ERR! cwd /home/pi/serialport/node_modules/serialport
gyp ERR! node -v v6.0.0-nightly20160307061ebb39c9
gyp ERR! node-gyp -v v3.2.1
gyp ERR! not ok 
node-pre-gyp ERR! build error 
node-pre-gyp ERR! stack Error: Failed to execute '/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/node /home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm/serialport.node --module_name=serialport --module_path=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/home/pi/serialport/node_modules/serialport/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at emitTwo (events.js:101:13)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:186:7)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:850:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
node-pre-gyp ERR! System Linux 4.1.18-v7+
node-pre-gyp ERR! command "/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/node" "/home/pi/serialport/node_modules/serialport/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /home/pi/serialport/node_modules/serialport
node-pre-gyp ERR! node -v v6.0.0-nightly20160307061ebb39c9
node-pre-gyp ERR! node-pre-gyp -v v0.6.18
node-pre-gyp ERR! not ok 
Failed to execute '/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/node /home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm/serialport.node --module_name=serialport --module_path=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm' (1)
npm WARN enoent ENOENT: no such file or directory, open '/home/pi/serialport/package.json'
npm WARN serialport No description
npm WARN serialport No repository field.
npm WARN serialport No README data
npm WARN serialport No license field.
npm WARN You are using a pre-release version of node and things may not work as expected
npm ERR! Linux 4.1.18-v7+
npm ERR! argv "/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/node" "/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/npm" "install" "[email protected]"
npm ERR! node v6.0.0-nightly20160307061ebb39c9
npm ERR! npm  v3.6.0
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the serialport package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs serialport
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls serialport
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/pi/serialport/npm-debug.log
pi@raspberrypi:~/serialport $

These compile errors are occurring because serialport depends on an old version of NAN (v2.0.9). Upgrading to NAN v2.2.1 solves the problem. There's a fork of serialport at https://github.com/fivdi/node-serialport with the corresponding NAN upgrade. It installs successfully and can read and write successfully. There's a corresponding PR at #707

pi@raspberrypi:~/serialport $ node -v
v6.0.0-nightly20160307061ebb39c9
pi@raspberrypi:~/serialport $ npm install "git://github.com/fivdi/node-serialport.git#master"
(node:7260) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.

> [email protected] install /home/pi/serialport/node_modules/serialport
> node-pre-gyp install --fallback-to-build

make: Entering directory '/home/pi/serialport/node_modules/serialport/build'
  CXX(target) Release/obj.target/serialport/src/serialport.o
  CXX(target) Release/obj.target/serialport/src/serialport_unix.o
  CXX(target) Release/obj.target/serialport/src/serialport_poller.o
  SOLINK_MODULE(target) Release/obj.target/serialport.node
  COPY Release/serialport.node
  COPY /home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm/serialport.node
  TOUCH Release/obj.target/action_after_build.stamp
make: Leaving directory '/home/pi/serialport/node_modules/serialport/build'
/home/pi/serialport
└─┬ [email protected]  (git://github.com/fivdi/node-serialport.git#1e14890c47675c850ff5c6a9ccee9557c815dac6)
  ├── [email protected] 
  ├── [email protected] 
  ├─┬ [email protected] 
  │ └── [email protected] 
  ├── [email protected] 

... 

  ├─┬ [email protected] 
  │ ├── [email protected] 
  │ └── [email protected] 
  └── [email protected] 

npm WARN enoent ENOENT: no such file or directory, open '/home/pi/serialport/package.json'
npm WARN serialport No description
npm WARN serialport No repository field.
npm WARN serialport No README data
npm WARN serialport No license field.
npm WARN You are using a pre-release version of node and things may not work as expected
pi@raspberrypi:~/serialport $

reconbot · 2016-03-30T13:34:48Z

Well this is the first node6 I've seen. Thanks!

On Wed, Mar 30, 2016, 6:49 AM Brian Cooke [email protected] wrote:

Raspbian Jessie 2016-02-26:

Node.js v0.10.29, v4.4.1, v5.9.1

installs successfully

tested with the UART at /dev/ttyAMA0 so I'm unsure what connect and
disconnect mean

reading and writing successful

Node.js v6.0.0-nightly20160307061ebb39c9

npm install [email protected] results in compile errors:

pi@raspberrypi:~/serialport $ npm install [email protected]
(node:7165) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.

[email protected] install /home/pi/serialport/node_modules/serialport
node-pre-gyp install --fallback-to-build

make: Entering directory '/home/pi/serialport/node_modules/serialport/build'
CXX(target) Release/obj.target/serialport/src/serialport.o
In file included from ../src/serialport.h:5:0,
from ../src/serialport.cpp:3:
../../nan/nan.h:590:20: error: variable or field ‘AddGCEpilogueCallback’ declared void
v8::Isolate::GCEpilogueCallback callback
^
../../nan/nan.h:590:7: error: ‘GCEpilogueCallback’ is not a member of ‘v8::Isolate’
v8::Isolate::GCEpilogueCallback callback
^
../../nan/nan.h:591:18: error: expected primary-expression before ‘gc_type_filter’
, v8::GCType gc_type_filter = v8::kGCTypeAll) {
^
../../nan/nan.h:596:20: error: variable or field ‘RemoveGCEpilogueCallback’ declared void
v8::Isolate::GCEpilogueCallback callback) {
^
../../nan/nan.h:596:7: error: ‘GCEpilogueCallback’ is not a member of ‘v8::Isolate’
v8::Isolate::GCEpilogueCallback callback) {
^
../../nan/nan.h:601:20: error: variable or field ‘AddGCPrologueCallback’ declared void
v8::Isolate::GCPrologueCallback callback
^
../../nan/nan.h:601:7: error: ‘GCPrologueCallback’ is not a member of ‘v8::Isolate’
v8::Isolate::GCPrologueCallback callback
^
../../nan/nan.h:602:18: error: expected primary-expression before ‘gc_type_filter’
, v8::GCType gc_type_filter = v8::kGCTypeAll) {
^
../../nan/nan.h:607:20: error: variable or field ‘RemoveGCPrologueCallback’ declared void
v8::Isolate::GCPrologueCallback callback) {
^
../../nan/nan.h:607:7: error: ‘GCPrologueCallback’ is not a member of ‘v8::Isolate’
v8::Isolate::GCPrologueCallback callback) {
^serialport.target.mk:90: recipe for target 'Release/obj.target/serialport/src/serialport.o' failed
make: *** [Release/obj.target/serialport/src/serialport.o] Error 1
make: Leaving directory '/home/pi/serialport/node_modules/serialport/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack at emitTwo (events.js:101:13)
gyp ERR! stack at ChildProcess.emit (events.js:186:7)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)
gyp ERR! System Linux 4.1.18-v7+
gyp ERR! command "/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/node" "/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm/serialport.node" "--module_name=serialport" "--module_path=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm"
gyp ERR! cwd /home/pi/serialport/node_modules/serialport
gyp ERR! node -v v6.0.0-nightly20160307061ebb39c9
gyp ERR! node-gyp -v v3.2.1
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute '/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/node /home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm/serialport.node --module_name=serialport --module_path=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm' (1)
node-pre-gyp ERR! stack at ChildProcess. (/home/pi/serialport/node_modules/serialport/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack at emitTwo (events.js:101:13)
node-pre-gyp ERR! stack at ChildProcess.emit (events.js:186:7)
node-pre-gyp ERR! stack at maybeClose (internal/child_process.js:850:16)
node-pre-gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
node-pre-gyp ERR! System Linux 4.1.18-v7+
node-pre-gyp ERR! command "/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/node" "/home/pi/serialport/node_modules/serialport/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /home/pi/serialport/node_modules/serialport
node-pre-gyp ERR! node -v v6.0.0-nightly20160307061ebb39c9
node-pre-gyp ERR! node-pre-gyp -v v0.6.18
node-pre-gyp ERR! not ok
Failed to execute '/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/node /home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm/serialport.node --module_name=serialport --module_path=/home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm' (1)
npm WARN enoent ENOENT: no such file or directory, open '/home/pi/serialport/package.json'
npm WARN serialport No description
npm WARN serialport No repository field.
npm WARN serialport No README data
npm WARN serialport No license field.
npm WARN You are using a pre-release version of node and things may not work as expected
npm ERR! Linux 4.1.18-v7+
npm ERR! argv "/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/node" "/home/pi/opt/node-v6.0.0-nightly20160307061ebb39c9-linux-armv7l/bin/npm" "install" "[email protected]"
npm ERR! node v6.0.0-nightly20160307061ebb39c9
npm ERR! npm v3.6.0
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: node-pre-gyp install --fallback-to-build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the serialport package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node-pre-gyp install --fallback-to-build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs serialport
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls serialport
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /home/pi/serialport/npm-debug.log
pi@raspberrypi:~/serialport $

These compile errors are occurring because serialport depends on an old
version of NAN (v2.0.9). Upgrading to NAN v2.2.1 solves the problem.
There's a fork of serialport at https://github.com/fivdi/node-serialport
with the corresponding NAN upgrade. It installs successfully and can read
and write successfully. There's a corresponding PR at #707
#707

pi@raspberrypi:/serialport $ node -v
v6.0.0-nightly20160307061ebb39c9
pi@raspberrypi:/serialport $ npm install "git://github.com/fivdi/node-serialport.git#master"
(node:7260) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.

[email protected] install /home/pi/serialport/node_modules/serialport
node-pre-gyp install --fallback-to-build

make: Entering directory '/home/pi/serialport/node_modules/serialport/build'
CXX(target) Release/obj.target/serialport/src/serialport.o
CXX(target) Release/obj.target/serialport/src/serialport_unix.o
CXX(target) Release/obj.target/serialport/src/serialport_poller.o
SOLINK_MODULE(target) Release/obj.target/serialport.node
COPY Release/serialport.node
COPY /home/pi/serialport/node_modules/serialport/build/Release/node-v47-linux-arm/serialport.node
TOUCH Release/obj.target/action_after_build.stamp
make: Leaving directory '/home/pi/serialport/node_modules/serialport/build'
/home/pi/serialport
└─┬ [email protected] (git://github.com/fivdi/node-serialport.git#1e14890c47675c850ff5c6a9ccee9557c815dac6)
├── [email protected]
├── [email protected]
├─┬ [email protected]
│ └── [email protected]
├── [email protected]

...

├─┬ [email protected]
│ ├── [email protected]
│ └── [email protected]
└── [email protected]

npm WARN enoent ENOENT: no such file or directory, open '/home/pi/serialport/package.json'
npm WARN serialport No description
npm WARN serialport No repository field.
npm WARN serialport No README data
npm WARN serialport No license field.
npm WARN You are using a pre-release version of node and things may not work as expected
pi@raspberrypi:~/serialport $

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#688 (comment)

fivdi · 2016-03-30T13:44:08Z

It probably won't be the last v6 issue :)

reconbot · 2016-03-30T13:51:19Z

Supporting it needs to be on the road map but it's behind a couple bugs.

On Wed, Mar 30, 2016, 9:44 AM Brian Cooke [email protected] wrote:

It probably won't be the last v6 issue :)

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#688 (comment)

reconbot · 2016-03-30T13:51:36Z

That is to say, patches welcome.

On Wed, Mar 30, 2016, 9:51 AM Francis Gulotta [email protected] wrote:

Supporting it needs to be on the road map but it's behind a couple bugs.

On Wed, Mar 30, 2016, 9:44 AM Brian Cooke [email protected]
wrote:

It probably won't be the last v6 issue :)

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#688 (comment)

fivdi · 2016-03-30T14:41:03Z

#707 will fix the v6.0.0-nightly20160307061ebb39c9 issue. Note that #707 may also help with #680 which has similar compile errors.

reconbot added the needs-testing label Mar 25, 2016

reconbot mentioned this issue Mar 25, 2016

'error' event callback doesn't work, emit error【TypeError: undefined is not a function】 #352

Closed

reconbot changed the title ~~Beta test [email protected]~~ Beta test [email protected] Mar 29, 2016

reconbot mentioned this issue Mar 29, 2016

this.fd = 0 treated as an error #472

Closed

reconbot mentioned this issue Mar 30, 2016

open () returning while fd is null #507

Closed

andrewjaykeller mentioned this issue Mar 30, 2016

Node 5 compatibility openbci-archive/OpenBCI_NodeJS#31

Closed

reconbot closed this as completed Apr 6, 2016

lock bot locked as resolved and limited conversation to collaborators May 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Beta test [email protected] #688

Beta test [email protected] #688

reconbot commented Mar 25, 2016

rwaldron commented Mar 28, 2016

reconbot commented Mar 29, 2016

fivdi commented Mar 30, 2016

reconbot commented Mar 30, 2016

fivdi commented Mar 30, 2016

reconbot commented Mar 30, 2016

reconbot commented Mar 30, 2016

fivdi commented Mar 30, 2016

Beta test [email protected] #688

Beta test [email protected] #688

Comments

reconbot commented Mar 25, 2016

rwaldron commented Mar 28, 2016

reconbot commented Mar 29, 2016

fivdi commented Mar 30, 2016

reconbot commented Mar 30, 2016

fivdi commented Mar 30, 2016

reconbot commented Mar 30, 2016

reconbot commented Mar 30, 2016

fivdi commented Mar 30, 2016