Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: for compatibility, code also have language #44

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

zaratan
Copy link
Contributor

@zaratan zaratan commented Nov 7, 2020

Some PrismJS themes expect <code> to also carry the language.

@hswolff
Copy link
Contributor

hswolff commented Nov 10, 2020

Would love to see this merged! When porting from Gatsby to Next.js I noticed this as a difference between how the two rendered.

@zaratan
Copy link
Contributor Author

zaratan commented Nov 10, 2020

@hswolff that's exactly why I created that PR. I'm using my fork now and everything is working perfectly.

@sergioramos
Copy link
Owner

Thank you so much for this @zaratan 👍

I just have a couple of questions, and will merge if you don't mind answering.

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@zaratan
Copy link
Contributor Author

zaratan commented Nov 10, 2020

That said. Maybe this should be put behind a compatible_mode option flag. What do you think @sergioramos ?

@zaratan
Copy link
Contributor Author

zaratan commented Nov 10, 2020

@sergioramos language-unknown seems better than language- and those theme would still work. IMO we don't need a compatibility flag on top of this then.

@zaratan zaratan requested a review from sergioramos November 10, 2020 19:19
@sergioramos sergioramos changed the title For compatibility, code also have language feat: for compatibility, code also have language Nov 13, 2020
@sergioramos sergioramos merged commit 3a3c448 into sergioramos:master Nov 13, 2020
@sergioramos
Copy link
Owner

thank you very much @zaratan 👍

@zaratan
Copy link
Contributor Author

zaratan commented Nov 13, 2020

Thank you for this project. It works very well :)

@hswolff hswolff mentioned this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants