Improve successRedirect and failureRedirect types #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an overload typing to the isAuthenticated function for if successRedirect and failureRedirect are both defined.
sergiodxa
reviewed
Apr 22, 2022
sergiodxa
reviewed
Apr 22, 2022
If a user is logged in, its going to redirect instead of returning the user, so will always be a null return.
sergiodxa
approved these changes
May 26, 2022
sergiodxa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an overload typing to the isAuthenticated function for if successRedirect and failureRedirect are both defined.
This fixes an issue where calling the function with both redirects specified will fail to compile.