[WIP] Support of NUnit3 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on NUnit3 source code I propose the following migration of the custom constraints. - We should add tests to prove the WriteDescriptionTo method migration is doing what is intended. - The F#-friendly formatting has been partially merged. We need to decide if the EqualConstraintResult class is good enough or if we inherit it and make it F#-friendly.
|
Seems like |
|
@sergey-tihon It seems to be the behavior of the other constraint classes. Besides the WriteDescriptionTo method was not displaying the actual value, was it? |
|
But |
|
@Evangelink Thank for this PR |
sergey-tihon
pushed a commit
that referenced
this pull request
Oct 30, 2019
Add collection supersetOf assertion for NUnit, xUnit and MsTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on NUnit3 source code I propose the following migration of the
custom constraints.
is doing what is intended.
decide if the EqualConstraintResult class is good enough or if we
inherit it and make it F#-friendly.