Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for IPv6 #1055

Merged
merged 45 commits into from
Jan 18, 2024
Merged

Add support for IPv6 #1055

merged 45 commits into from
Jan 18, 2024

Conversation

Smartappli
Copy link
Contributor

@Smartappli Smartappli commented Jan 13, 2024 •
edited by gaby
Loading

Fixes #652

@Smartappli
Update deploy.sh
e4b6d7f 
add support ipv6
@Smartappli
Update dev.sh
b8bafe2 
add support for ipv6
@Smartappli
Update deploy.sh
5288650 
add support for ipv6
@Smartappli
Update deploy.sh
bc66aa2 
add support for ipv6
@Smartappli
Update dev.sh
2927845 
support  for ipv6
@Smartappli
Update dev.sh
a4b6458 
support for ipv6 reworked
Thanks Gaby :)
@Smartappli
Update serge.env
0508f5b 
add support for ipv6
@Smartappli
Update deploy.sh
89647f2 
support for ipv6 reworked
Thanks Gaby :)
@Smartappli
Update deploy.sh
4dd5e7d 
bugfix
@Smartappli
Update serge.env
26b99dc
@Smartappli
Update serge.env
df5517c 
rename variable in SERGE_ENABLE_IPV6
@Smartappli
Update deploy.sh
e4e304c 
rename variable in SERGE_ENABLE_IPV6
@Smartappli
Update dev.sh
a23cc22 
rename variable in SERGE_ENABLE_IPV6
@Smartappli
Update deploy.sh
c5a634e 
remove redudant code
@Smartappli
Update dev.sh
daba9c7 
add missing code
@Smartappli
Update deploy.sh
d90375e 
tiny change
@Smartappli Smartappli changed the title Support for IPv4 and IPv6 Support for IPv4 or IPv6 Jan 13, 2024
@gaby gaby changed the title Support for IPv4 or IPv6 Add support for IPv6 Jan 14, 2024
@gaby
Copy link
Member

gaby commented Jan 14, 2024 •
edited
Loading

@Smartappli We need to migrate to hypercorn, else we will be running 2 servers at the same time.

See here: encode/uvicorn#1529 (reply in thread)

@Smartappli
Update deploy.sh
8cdf703 
change unicorn by hypercorn
@Smartappli
Update serge.env
8eeab40 
delete unecessary param
@Smartappli
Update dev.sh
a56b1a7 
replace unicorn by hypercorn
@Smartappli
Copy link
Contributor Author

@Smartappli We need to migrate to hypercorn, else we will be running 2 servers at the same time.

See here: encode/uvicorn#1529 (reply in thread)

thanks :)

Smartappli and others added 4 commits January 14, 2024 19:46
@Smartappli
Update pyproject.toml
8b91b0c 
replace unicorn by hypercorn
@Smartappli
Update poetry.lock
44f5ae8 
replace unicorn by hypercorn
@gaby
Merge branch 'main' into ipv6
b35d11b
@Smartappli
Update poetry.lock
2cc1a6d 
poetry updated
@Smartappli
Update pyproject.toml
dbd1b25 
update
@Smartappli
Update poetry.lock
1b5189f 
hypercorn update
@Smartappli
Update deploy.sh
5dbaa93 
shmft applied
@Smartappli
Update dev.sh
2e2a10f 
shmft applied
@Smartappli
Update deploy.sh
29cdd09 
shmft applied
@Smartappli
Update dev.sh
c22b50a 
shmft applied
@Smartappli
Update dev.sh
5a6e748 
bugfix
@Smartappli
Update serge.env
698d41e 
missing value
gaby
gaby requested changes Jan 15, 2024
View reviewed changes
scripts/deploy.sh Outdated Show resolved Hide resolved
scripts/serge.env Outdated Show resolved Hide resolved
scripts/dev.sh Outdated Show resolved Hide resolved
@Smartappli
Update deploy.sh
ab9452c 
code corrected
@Smartappli
Update dev.sh
e18e0ce 
code corrected
@Smartappli
Update serge.env
722ac71 
 code corrected
@Smartappli Smartappli requested a review from gaby January 15, 2024 17:24
gaby
gaby requested changes Jan 16, 2024
View reviewed changes
scripts/deploy.sh Outdated Show resolved Hide resolved
scripts/dev.sh Outdated Show resolved Hide resolved
@Smartappli
Update serge.env
e2e2b8c
@Smartappli
Update deploy.sh
7a41f47 
add SERGE_IPV6_SUPPORT
@Smartappli
Update dev.sh
487248b 
Add SERGE_IPV6_SUPPORT
@Smartappli Smartappli requested a review from gaby January 16, 2024 18:29
@gaby
Copy link
Member

gaby commented Jan 18, 2024

@Smartappli Can you take a look at the merge conflicts

@gaby gaby merged commit f9d8ed2 into serge-chat:main Jan 18, 2024
10 checks passed
@Smartappli Smartappli deleted the ipv6 branch January 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaby gaby gaby approved these changes

Assignees
No one assigned
Labels
✏️ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPv6 Support
2 participants
@Smartappli @gaby