Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracks: Remove box around TrackState #84

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Tracks: Remove box around TrackState #84

merged 1 commit into from
Jun 29, 2021

Conversation

vilgotf
Copy link
Contributor

@vilgotf vilgotf commented Jun 28, 2021

Boxing is unnecessary since TrackState implements copy.

Tested using cargo make ready

FelixMcFelix
FelixMcFelix approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@FelixMcFelix FelixMcFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm. I think there was an earlier version of TrackState which had at least one non-Copy member, glad this is improved now. :)

@FelixMcFelix FelixMcFelix added breaking Will either cause existing code to fail to compile, or cause substantial behaviour changes enhancement New feature or request tracks Relates to audio control, state, or lifecycle management. labels Jun 29, 2021
@FelixMcFelix FelixMcFelix merged commit e1b0469 into serenity-rs:next Jun 29, 2021
FelixMcFelix pushed a commit to FelixMcFelix/songbird that referenced this pull request Jul 1, 2021
@vilgotf @FelixMcFelix
Tracks: Remove box around TrackState (serenity-rs#84)
91d7542 
Boxing is unnecessary since `TrackState` implements copy.

Tested using `cargo make ready`.
@vilgotf vilgotf deleted the fixup/remove-TrackState-box branch August 5, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixMcFelix FelixMcFelix FelixMcFelix approved these changes

Assignees
No one assigned
Labels
breaking Will either cause existing code to fail to compile, or cause substantial behaviour changes enhancement New feature or request tracks Relates to audio control, state, or lifecycle management.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vilgotf @FelixMcFelix