Driver: remove sample buffer copy for softclip #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixMcFelix
added
enhancement
FelixMcFelix
added a commit
to FelixMcFelix/songbird
that referenced
this pull request
Dec 15, 2022
Temporary measure until symphonia 0.5.2 is released. Should allow us to merge serenity-rs#143 now that all our API additions and fixes are in.
FelixMcFelix
added a commit
that referenced
this pull request
Dec 15, 2022
Temporary measure until symphonia 0.5.2 is released. Should allow us to merge #143 now that all our API additions and fixes are in.
FelixMcFelix
added a commit
to FelixMcFelix/songbird
that referenced
this pull request
Nov 20, 2023
Temporary measure until symphonia 0.5.2 is released. Should allow us to merge serenity-rs#143 now that all our API additions and fixes are in.
FelixMcFelix
added a commit
to FelixMcFelix/songbird
that referenced
this pull request
Nov 20, 2023
This PR makes use of `SampleBuffer::samples_mut` to remove a 7680B stack allocation in general, and memcopy when softclip is used. This appears to offer ~1.5% performance boost according to `cargo make bench`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of
SampleBuffer::samples_mutto remove a 7680B stack allocation in general, and memcopy when softclip is used. This appears to offer ~1.5% performance boost according tocargo make bench.This is a draft PR conditioned on the relevant symphonia API change becoming available.