Factor out collector methods on models into traits #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
mkrasnitski
added
the
breaking change
mkrasnitski
force-pushed
the
collector-traits
branch
from
216fb03 to
e80b387
Compare
GnomedDev
approved these changes
Nov 25, 2024
mkrasnitski
force-pushed
the
collector-traits
branch
from
e80b387 to
442e25b
Compare
arqunis
approved these changes
Nov 27, 2024
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Dec 8, 2024
Moves the feature-gated collector methods on `UserId`, `MessageId`, etc. into four traits: - `CollectMessages` - `CollectReactions` - `CollectModalInteractions` - `CollectComponentInteractions` This also moves the quick modal machinery into the collector module and defines a `QuickModal` trait. This fully removes any collector feature gates from the model types.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 16, 2025
Moves the feature-gated collector methods on `UserId`, `MessageId`, etc. into four traits: - `CollectMessages` - `CollectReactions` - `CollectModalInteractions` - `CollectComponentInteractions` This also moves the quick modal machinery into the collector module and defines a `QuickModal` trait. This fully removes any collector feature gates from the model types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the feature-gated collector methods on
UserId,MessageId, etc. into four traits namedCollectMessages,CollectReactions,CollectModalInteractionsandCollectComponentInteractions. Also, move the quick modal machinery into the collector module and define aQuickModaltrait. This fully removes any collector feature gates from the model types.