Fix model functions using SerializeIter #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
arqunis
added
enhancement
arqunis
approved these changes
Aug 26, 2024
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 7, 2024
When passing `SerializeIter` in from outside, it counts as passing `!Send` over an await point and therefore making these functions unusable. This fixes that by moving the `SerializeIter` usage inside of `Http`, or replacing with a slice when necessary.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 20, 2024
When passing `SerializeIter` in from outside, it counts as passing `!Send` over an await point and therefore making these functions unusable. This fixes that by moving the `SerializeIter` usage inside of `Http`, or replacing with a slice when necessary.
GnomedDev
added a commit
that referenced
this pull request
Oct 20, 2024
When passing `SerializeIter` in from outside, it counts as passing `!Send` over an await point and therefore making these functions unusable. This fixes that by moving the `SerializeIter` usage inside of `Http`, or replacing with a slice when necessary.
arqunis
pushed a commit
that referenced
this pull request
Oct 28, 2024
This is a backport of #2955 to `current`. `bulk_ban` is currently uncallable so this "breaking" change doesn't actually break anyone.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 11, 2024
When passing `SerializeIter` in from outside, it counts as passing `!Send` over an await point and therefore making these functions unusable. This fixes that by moving the `SerializeIter` usage inside of `Http`, or replacing with a slice when necessary.
GnomedDev
added a commit
that referenced
this pull request
Nov 13, 2024
When passing `SerializeIter` in from outside, it counts as passing `!Send` over an await point and therefore making these functions unusable. This fixes that by moving the `SerializeIter` usage inside of `Http`, or replacing with a slice when necessary.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 15, 2024
When passing `SerializeIter` in from outside, it counts as passing `!Send` over an await point and therefore making these functions unusable. This fixes that by moving the `SerializeIter` usage inside of `Http`, or replacing with a slice when necessary.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Dec 8, 2024
When passing `SerializeIter` in from outside, it counts as passing `!Send` over an await point and therefore making these functions unusable. This fixes that by moving the `SerializeIter` usage inside of `Http`, or replacing with a slice when necessary.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 16, 2025
When passing `SerializeIter` in from outside, it counts as passing `!Send` over an await point and therefore making these functions unusable. This fixes that by moving the `SerializeIter` usage inside of `Http`, or replacing with a slice when necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing SerializeIter in from outside, it counts as passing !Send over an await point and therefore making these functions unusable. This fixes that by moving the SerializeIter usage inside of
Http, or replacing with a slice when necessary.