Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cache from most builders #2855

Merged
merged 3 commits into from
May 1, 2024
Merged

Remove cache from most builders #2855

merged 3 commits into from
May 1, 2024

Conversation

jamesbt365
Copy link
Member

@jamesbt365 jamesbt365 commented Apr 29, 2024 •
edited
Loading

Users should realistically be checking the permissions themselves, or handling the http error from Discord.

This removes any cases where permission checking inside the library is broken because discord changes or just over oversights.

Also changes the documentation on the prune functionality, this was recently changed to also require MANAGE_GUILDS as well as KICK_MEMBERS.

Please check for any impl CacheHttp's being replaced with Http, they should be replaced with &Http or places where i may have skewed the docs.

@github-actions github-actions bot added model Related to the `model` module. client Related to the `client` module. builder Related to the `builder` module. utils Related to the `utils` module. examples Related to Serenity's examples. labels Apr 29, 2024
@jamesbt365 jamesbt365 marked this pull request as draft April 29, 2024 16:05
@jamesbt365 jamesbt365 force-pushed the invalid-permissions-removal branch from 61f5229 to f0066a7 Compare April 29, 2024 16:28
@jamesbt365 jamesbt365 marked this pull request as ready for review April 29, 2024 16:31
GnomedDev
GnomedDev approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@GnomedDev GnomedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small nitpick. Since I suggested the change, it's probably best if there can be another review though.

src/model/channel/message.rs Outdated Show resolved Hide resolved
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Apr 30, 2024
arqunis
arqunis requested changes Apr 30, 2024
View reviewed changes
src/model/channel/message.rs Outdated Show resolved Hide resolved
src/model/channel/message.rs Outdated Show resolved Hide resolved
src/model/channel/message.rs Outdated Show resolved Hide resolved
src/model/channel/message.rs Outdated Show resolved Hide resolved
src/model/channel/message.rs Outdated Show resolved Hide resolved
src/model/invite.rs Outdated Show resolved Hide resolved
@jamesbt365
Copy link
Member Author

Hopefully that suggestion passes CI on its own, otherwise I'll fix it in an actual editor lol.

@jamesbt365 jamesbt365 force-pushed the invalid-permissions-removal branch from 70481b8 to 5e99188 Compare April 30, 2024 23:22
@jamesbt365
Copy link
Member Author

it did not 👍

@jamesbt365 jamesbt365 requested a review from arqunis April 30, 2024 23:25
@arqunis arqunis merged commit de04826 into serenity-rs:next May 1, 2024
21 checks passed
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@jamesbt365 @GnomedDev
Remove permission checks (serenity-rs#2855)
070adb7 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit that referenced this pull request May 14, 2024
@jamesbt365 @GnomedDev
Remove permission checks (#2855)
cf80116 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit that referenced this pull request May 23, 2024
@jamesbt365 @GnomedDev
Remove permission checks (#2855)
f7351ad 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit that referenced this pull request May 28, 2024
@jamesbt365 @GnomedDev
Remove permission checks (#2855)
1aa2e9b 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@jamesbt365 @GnomedDev
Remove permission checks (serenity-rs#2855)
f01fd2b 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit that referenced this pull request Jun 22, 2024
@jamesbt365 @GnomedDev
Remove permission checks (#2855)
de5e433 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@jamesbt365 @GnomedDev
Remove permission checks (serenity-rs#2855)
eec5dd8 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@jamesbt365 @mkrasnitski
Remove permission checks (serenity-rs#2855)
ae0d4b3 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@jamesbt365 @mkrasnitski
Remove permission checks (serenity-rs#2855)
cfd8a01 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit that referenced this pull request Aug 16, 2024
@jamesbt365 @GnomedDev
Remove permission checks (#2855)
2b72834 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@jamesbt365 @GnomedDev
Remove permission checks (serenity-rs#2855)
f2de3fa 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@jamesbt365 @GnomedDev
Remove permission checks (serenity-rs#2855)
2e66a4d 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit that referenced this pull request Oct 20, 2024
@jamesbt365 @GnomedDev
Remove permission checks (#2855)
aa041d3 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@jamesbt365 @GnomedDev
Remove permission checks (serenity-rs#2855)
8886bf3 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit that referenced this pull request Nov 13, 2024
@jamesbt365 @GnomedDev
Remove permission checks (#2855)
c1d1fe3 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@jamesbt365 @GnomedDev
Remove permission checks (serenity-rs#2855)
ae5bb4c 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@jamesbt365 @mkrasnitski
Remove permission checks (serenity-rs#2855)
86975b8 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@jamesbt365 @arqunis
Remove permission checks (serenity-rs#2855)
226f1b6 
Users should realistically be checking the permissions themselves, or
handling the HTTP error from Discord.

This removes any cases where permission checking inside the library is
broken because of Discord's changes or due to oversights.

This also changes the documentation on the prune functionality, this was
recently changed to also require `MANAGE_GUILDS` as well as
`KICK_MEMBERS`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GnomedDev GnomedDev GnomedDev approved these changes

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. client Related to the `client` module. enhancement An improvement to Serenity. examples Related to Serenity's examples. model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesbt365 @arqunis @GnomedDev