Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore match arm for Error::Gateway variant #2847

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Restore match arm for Error::Gateway variant #2847

merged 1 commit into from
Apr 22, 2024

Conversation

mkrasnitski
Copy link
Collaborator

This was mistakenly removed in #2278 and wasn't caught because of the wildcard pattern in the match.

@GnomedDev
Copy link
Member

Can you spell out the variants being caught by the wildcard, so this doesn't happen again?

@mkrasnitski
Copy link
Collaborator Author

I removed the wildcard, so there are no extra variants being caught by it anymore.

GnomedDev
GnomedDev approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@GnomedDev GnomedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm silly!

@GnomedDev GnomedDev merged commit 39a0574 into serenity-rs:next Apr 22, 2024
21 checks passed
@arqunis arqunis added the fix A solution to an existing bug. label Apr 22, 2024
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (serenity-rs#2847)
8e2e803 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit that referenced this pull request May 14, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (#2847)
dcef7f1 
This was mistakenly removed in #2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit that referenced this pull request May 23, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (#2847)
49abab7 
This was mistakenly removed in #2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit that referenced this pull request May 28, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (#2847)
13e3f9c 
This was mistakenly removed in #2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (serenity-rs#2847)
b213438 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit that referenced this pull request Jun 22, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (#2847)
37beb67 
This was mistakenly removed in #2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (serenity-rs#2847)
a725fda 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@mkrasnitski
Restore match arm for Error::Gateway variant (serenity-rs#2847)
a8c3fa0 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@mkrasnitski
Restore match arm for Error::Gateway variant (serenity-rs#2847)
a5ebccf 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit that referenced this pull request Aug 16, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (#2847)
e87fe3d 
This was mistakenly removed in #2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (serenity-rs#2847)
14be03a 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (serenity-rs#2847)
54e451a 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit that referenced this pull request Oct 20, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (#2847)
34fd74d 
This was mistakenly removed in #2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (serenity-rs#2847)
520d0e7 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit that referenced this pull request Nov 13, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (#2847)
9bfcb66 
This was mistakenly removed in #2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@mkrasnitski @GnomedDev
Restore match arm for Error::Gateway variant (serenity-rs#2847)
cec3ca5 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@mkrasnitski
Restore match arm for Error::Gateway variant (serenity-rs#2847)
67ccedd 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@mkrasnitski @arqunis
Restore match arm for Error::Gateway variant (serenity-rs#2847)
d75a77e 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@mkrasnitski
Restore match arm for Error::Gateway variant (serenity-rs#2847)
64aa204 
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GnomedDev GnomedDev GnomedDev approved these changes

Assignees
No one assigned
Labels
fix A solution to an existing bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkrasnitski @GnomedDev @arqunis