Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add audit log reasons to remaining model methods #2821

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Add audit log reasons to remaining model methods #2821

merged 2 commits into from
Mar 29, 2024

Conversation

GnomedDev
Copy link
Member

This should sort this out once and for all.

@github-actions github-actions bot added model Related to the `model` module. builder Related to the `builder` module. examples Related to Serenity's examples. labels Mar 29, 2024
jamesbt365
jamesbt365 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@jamesbt365 jamesbt365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than forgetting to put arguments in some places it looks good to me.

@GnomedDev GnomedDev force-pushed the consistent-audit-log-reason branch from 2a842f3 to be8d079 Compare March 29, 2024 19:50
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Mar 29, 2024
@arqunis arqunis merged commit 05cff96 into serenity-rs:next Mar 29, 2024
21 checks passed
@GnomedDev GnomedDev deleted the consistent-audit-log-reason branch March 29, 2024 20:13
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Add audit log reasons to remaining model methods (#2821)
8e7f857
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Add audit log reasons to remaining model methods (#2821)
6a9b659
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Add audit log reasons to remaining model methods (serenity-rs#2821)
f077c22
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Add audit log reasons to remaining model methods (serenity-rs#2821)
57c47dd
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Add audit log reasons to remaining model methods (serenity-rs#2821)
e16ed49
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Add audit log reasons to remaining model methods (#2821)
4e78054
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Add audit log reasons to remaining model methods (#2821)
4f33986
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Add audit log reasons to remaining model methods (#2821)
ed4126d
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Add audit log reasons to remaining model methods (serenity-rs#2821)
2b46d93
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Add audit log reasons to remaining model methods (#2821)
47866e7
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Add audit log reasons to remaining model methods (serenity-rs#2821)
97e3b1f
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Add audit log reasons to remaining model methods (serenity-rs#2821)
9046bc0
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Add audit log reasons to remaining model methods (serenity-rs#2821)
691245c
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Add audit log reasons to remaining model methods (#2821)
f273c57
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Add audit log reasons to remaining model methods (serenity-rs#2821)
1fcee57
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Add audit log reasons to remaining model methods (serenity-rs#2821)
d3d09cd
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Add audit log reasons to remaining model methods (#2821)
f7530bf
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Add audit log reasons to remaining model methods (serenity-rs#2821)
b69644d
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Add audit log reasons to remaining model methods (#2821)
195ef38
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Add audit log reasons to remaining model methods (serenity-rs#2821)
a28b331
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Add audit log reasons to remaining model methods (serenity-rs#2821)
b0d83f1
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Add audit log reasons to remaining model methods (serenity-rs#2821)
8263207
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Add audit log reasons to remaining model methods (serenity-rs#2821)
d67cbc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbt365 jamesbt365 jamesbt365 approved these changes

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. enhancement An improvement to Serenity. examples Related to Serenity's examples. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GnomedDev @arqunis @jamesbt365