Make Guild::shard_id follow additive features #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
GnomedDev
force-pushed
the
remove-fancy-shard-id
branch
from
7f41139 to
6f4c516
Compare
arqunis
added
enhancement
arqunis
approved these changes
Mar 21, 2024
GnomedDev
added a commit
that referenced
this pull request
Mar 25, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
that referenced
this pull request
Mar 25, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
that referenced
this pull request
Mar 29, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
that referenced
this pull request
Mar 31, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 31, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Apr 1, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
May 14, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
that referenced
this pull request
May 14, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
that referenced
this pull request
May 23, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
that referenced
this pull request
May 28, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 9, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
that referenced
this pull request
Jun 22, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 22, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 29, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 30, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
that referenced
this pull request
Aug 16, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 7, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 20, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
that referenced
this pull request
Oct 20, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 11, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
that referenced
this pull request
Nov 13, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 15, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Dec 8, 2024
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 16, 2025
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 1, 2025
This PR: - Removes the `cache` feature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance - Removes the useless example that just showed how to call a function - Removed duplicate documentation on Guild, PartialGuild, and InviteGuild just to direct to the canonical documentation where the function is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
cachefeature locked function that called shard_count for the user, since that is useless and breaks the "all features should be additive" guidance