Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert enum number into wrapper struct to save type sizes #2746

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Convert enum number into wrapper struct to save type sizes #2746

merged 1 commit into from
Jan 29, 2024

Conversation

GnomedDev
Copy link
Member

Saves a couple bytes in each model by replacing the enums with a simpler and more accurate representation, a newtype with named statics. https://www.diffchecker.com/ohzayL9Z/

@github-actions github-actions bot added the model Related to the `model` module. label Jan 28, 2024
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Jan 29, 2024
@GnomedDev GnomedDev merged commit e1f90df into serenity-rs:next Jan 29, 2024
21 checks passed
@GnomedDev GnomedDev deleted the enum-number-struct branch January 29, 2024 18:46
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
1f22748 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
arqunis pushed a commit that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Convert enum number into wrapper struct to save type sizes (#2746)
c6d5db4 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
dc9e482 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
ffc863c 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
ad0cbb3 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
e81f662 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
d933a64 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
7678ebc 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
54199a3 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
e29bea4 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
a6491c6 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
b867f78 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
a60ce7d 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
baffcea 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
8f4d18f 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
334e819 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
32a6682 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
242547c 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
aa9d38d 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
fe7af60 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
a14480e 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
6eb6e0c 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
e9dab94 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Convert enum number into wrapper struct to save type sizes (serenity-…
f6e02e8 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Convert enum number into wrapper struct to save type sizes (serenity-…
ea9a67d 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
990d31d 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
55d4704 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
7ff5124 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
396ae58 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
e5a737f 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (#2746)
8fa66b1 
Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Convert enum number into wrapper struct to save type sizes (serenity-…
ee405e9 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Convert enum number into wrapper struct to save type sizes (serenity-…
079dd4f 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Convert enum number into wrapper struct to save type sizes (serenity-…
d4a3c5b 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Convert enum number into wrapper struct to save type sizes (serenity-…
305d5a2 
…rs#2746)

Saves a couple bytes in each model by replacing the enums with a simpler
and more accurate representation, a newtype with named statics.
https://www.diffchecker.com/ohzayL9Z/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis