Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RoleTags deserialisation after removal of simd-json #2742

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

GnomedDev
Copy link
Member

There was a comment here that said it was called by simd-json, so I removed the function, but it turns out that serde_json also calls it.

@github-actions github-actions bot added the model Related to the `model` module. label Jan 26, 2024
@GnomedDev GnomedDev merged commit a4a06a4 into serenity-rs:next Jan 26, 2024
21 checks passed
@GnomedDev GnomedDev deleted the fix-roletags-unit branch January 26, 2024 12:16
GnomedDev added a commit that referenced this pull request Feb 9, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
arqunis pushed a commit that referenced this pull request Mar 1, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Mar 10, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Mar 13, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Mar 21, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Mar 29, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request May 14, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request May 23, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request May 28, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Jun 22, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Aug 16, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Oct 20, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit that referenced this pull request Nov 13, 2024
There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
…2742)

There was a comment here that said it was called by simd-json, so I
removed the function, but it turns out that serde_json also calls it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant