Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FixedArray and FixedString in model enums #2675

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Use FixedArray and FixedString in model enums #2675

merged 1 commit into from
Dec 28, 2023

Conversation

GnomedDev
Copy link
Member

Simply missed these when finding and replacing.

@github-actions github-actions bot added the model Related to the `model` module. label Dec 28, 2023
arqunis
arqunis approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@arqunis arqunis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, it just needs a rebase on top of the current next. I just rebased next because the code surrounding RolesAdded and RolesRemoved has changed on current.

@GnomedDev
Copy link
Member Author

Rebased

@arqunis arqunis merged commit 8fb60db into serenity-rs:next Dec 28, 2023
22 checks passed
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Dec 28, 2023
@GnomedDev GnomedDev deleted the enum-fixedarray branch December 28, 2023 16:20
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 2, 2024
@GnomedDev @arqunis
Use FixedArray and FixedString in model enums (serenity-rs#2675)
40159ba 
Simply missed these when finding and replacing.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 5, 2024
@GnomedDev @arqunis
Use FixedArray and FixedString in model enums (serenity-rs#2675)
c3882b2 
Simply missed these when finding and replacing.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2024
@GnomedDev @arqunis
Use FixedArray and FixedString in model enums (serenity-rs#2675)
2addecd 
Simply missed these when finding and replacing.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 22, 2024
@GnomedDev @arqunis
Use FixedArray and FixedString in model enums (serenity-rs#2675)
4a159a3 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
4c6074c 
Simply missed these when finding and replacing.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Use FixedArray and FixedString in model enums (serenity-rs#2675)
76c1ea2 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
8933adc 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
3178622 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
3c684a2 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
deb4def 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
226730e 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
057d7e5 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
c672569 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
9f9d439 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
327f318 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
9ccd061 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
6c3a3cf 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
3944248 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
7380ca0 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
62092cb 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
427de12 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
bd87341 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
337edb8 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
eb0a598 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
69077f3 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
c41ab3d 
Simply missed these when finding and replacing.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Use FixedArray and FixedString in model enums (serenity-rs#2675)
c2cde4b 
Simply missed these when finding and replacing.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Use FixedArray and FixedString in model enums (serenity-rs#2675)
8f9f764 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
b51a526 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
424e8c3 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
d0f0420 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
3c04e62 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
8aff78b 
Simply missed these when finding and replacing.
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (#2675)
d15ed19 
Simply missed these when finding and replacing.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Use FixedArray and FixedString in model enums (serenity-rs#2675)
6b74b4b 
Simply missed these when finding and replacing.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Use FixedArray and FixedString in model enums (serenity-rs#2675)
137bb74 
Simply missed these when finding and replacing.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Use FixedArray and FixedString in model enums (serenity-rs#2675)
42caf58 
Simply missed these when finding and replacing.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Use FixedArray and FixedString in model enums (serenity-rs#2675)
fc25902 
Simply missed these when finding and replacing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis