Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Embed::fields using Vec instead of FixedArray #2674

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Fix Embed::fields using Vec instead of FixedArray #2674

merged 1 commit into from
Dec 28, 2023

Conversation

GnomedDev
Copy link
Member

Embed::fields previously had to stay Vec due to CreateEmbed wrapping around it, but by implementing serialize manually we can overwrite the Embed::fields with a normal Vec, for a small performance hit on serializing while saving some space for all Embeds stored. https://www.diffchecker.com/TkcWMGsd/

@github-actions github-actions bot added model Related to the `model` module. builder Related to the `builder` module. labels Dec 28, 2023
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Dec 28, 2023
@arqunis arqunis merged commit fbdaae2 into serenity-rs:next Dec 28, 2023
22 checks passed
arqunis pushed a commit to arqunis/serenity that referenced this pull request Dec 28, 2023
@GnomedDev @arqunis
Change Embed::fields to use FixedArray (serenity-rs#2674)
08f6bbb 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 2, 2024
@GnomedDev @arqunis
Change Embed::fields to use FixedArray (serenity-rs#2674)
57571cd 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 5, 2024
@GnomedDev @arqunis
Change Embed::fields to use FixedArray (serenity-rs#2674)
8d3501f 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2024
@GnomedDev @arqunis
Change Embed::fields to use FixedArray (serenity-rs#2674)
758c974 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 22, 2024
@GnomedDev @arqunis
Change Embed::fields to use FixedArray (serenity-rs#2674)
8c97364 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
2aa7074 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Change Embed::fields to use FixedArray (serenity-rs#2674)
b299135 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
de735f7 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
04e3912 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
1f5c0bf 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
076e787 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
53bd776 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
8d4456e 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
a1e0cac 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
320e5ad 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
54d69d3 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
292a74c 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
ebbdc10 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
f357da7 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
84f0ebd 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
81bf080 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
9b5b068 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
3456ba2 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
8e99832 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
916dd12 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
41d91f2 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
5e0bda1 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Change Embed::fields to use FixedArray (serenity-rs#2674)
cd5da84 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Change Embed::fields to use FixedArray (serenity-rs#2674)
b623ffb 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
55781e5 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
6617e5f 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
deb151a 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
1605c74 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
959b8be 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Change Embed::fields to use FixedArray (#2674)
cb979ca 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Change Embed::fields to use FixedArray (serenity-rs#2674)
eb85287 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Change Embed::fields to use FixedArray (serenity-rs#2674)
bda5a37 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Change Embed::fields to use FixedArray (serenity-rs#2674)
8affe80 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Change Embed::fields to use FixedArray (serenity-rs#2674)
23431e7 
`Embed::fields` previously had to stay as a `Vec` due to `CreateEmbed` wrapping
around it, but by implementing `Serialize` manually we can overwrite the
`Embed::fields` with a normal `Vec`, for a small performance hit on
serialization while saving some space for all stored `Embed`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. enhancement An improvement to Serenity. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis