New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FixedString<u8> truncation when multibyte characters push over the limit #2660

Merged

arqunis merged 1 commit into serenity-rs:next from GnomedDev:fix-u8-fixedstrings

Dec 14, 2023

Member

GnomedDev commented Dec 11, 2023

This caused an issue where one GuildChannel had a name over 255 bytes, but under 100 characters, so I did another pass over and increased lengths when needed. In practice without this the only problem is an annoying error log and the name being truncated, but good to fix anyway.


          Fix FixedString<u8> truncation when multibyte characters push over th…

a22d87d

…e limit

github-actions bot added the model label

arqunis added fix breaking change labels

arqunis merged commit 3db1ffc into serenity-rs:next

22 checks passed

GnomedDev deleted the fix-u8-fixedstrings branch

December 19, 2023 18:00

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

4df3080

…s push over the limit (serenity-rs#2660)

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

5922a1f

…s push over the limit (serenity-rs#2660)

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

3afa1df

…s push over the limit (serenity-rs#2660)

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

2857f51

…s push over the limit (serenity-rs#2660)

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

987ab43

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

a0c2e9c

…s push over the limit (#2660)

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

5aa65f2

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

f880406

…s push over the limit (#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

75f0bff

…s push over the limit (#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

9eb7893

…s push over the limit (#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

c899ffd

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

…s push over the limit (#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

c29039d

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

dd0a145

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

…s push over the limit (#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

1a21655

…s push over the limit (#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

0558ac2

…s push over the limit (#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

a6e25b3

…s push over the limit (#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

6889a04

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

912555e

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

4dba59a

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

6a2c504

…s push over the limit (#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

49bb8f2

…s push over the limit (#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

f753fee

…s push over the limit (#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

2db8487

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

fbc8034

…s push over the limit (#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

2e3886c

…s push over the limit (serenity-rs#2660)

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

d1e1781

…s push over the limit (serenity-rs#2660)

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

06414be

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

cf025b8

…s push over the limit (#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

81eeb52

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

37038d6

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

2867c3f

…s push over the limit (#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

c17131c

…s push over the limit (serenity-rs#2660)

GnomedDev added a commit that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

543c6cf

…s push over the limit (#2660)

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

1a961ac

…s push over the limit (serenity-rs#2660)

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

9dc055a

…s push over the limit (serenity-rs#2660)

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Fix truncation when using FixedString<u8> where multibyte character…

47d72e9

…s push over the limit (serenity-rs#2660)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change fix model