Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The get_channel_archived_public_threads method doesn't encode the timestamp well #2664

Closed
Kerollmops opened this issue Dec 17, 2023 · 1 comment · Fixed by #2665
Closed

The get_channel_archived_public_threads method doesn't encode the timestamp well #2664

Kerollmops opened this issue Dec 17, 2023 · 1 comment · Fixed by #2665

Comments

@Kerollmops
Copy link

While using the Http::get_channel_archived_public_threads method I got an error due to a miss-encoded before argument. The method asks for an Option<u64> but should rather ask for an Option<Timestamp> and encode it in ISO8601 as described in the documentation.

Error: Invalid Form Body (before: Could not parse 1700059153. Should be ISO8601.)

Caused by:
    Invalid Form Body (before: Could not parse 1700059153. Should be ISO8601.)
@Kerollmops Kerollmops mentioned this issue Dec 17, 2023
Merged
arqunis pushed a commit that referenced this issue Dec 22, 2023
@Kerollmops
Encode timestamps in RFC3339 (#2665)
7ccc2f2 
Fixes #2664
@mkrasnitski
Copy link
Collaborator

Closed by #2665.

arqunis pushed a commit to arqunis/serenity that referenced this issue Dec 28, 2023
@Kerollmops @arqunis
Encode timestamps in RFC3339 (serenity-rs#2665)
756ae5f 
Fixes serenity-rs#2664
arqunis pushed a commit to arqunis/serenity that referenced this issue Jan 2, 2024
@Kerollmops @arqunis
Encode timestamps in RFC3339 (serenity-rs#2665)
3bcb1cb 
Fixes serenity-rs#2664
arqunis pushed a commit to arqunis/serenity that referenced this issue Jan 5, 2024
@Kerollmops @arqunis
Encode timestamps in RFC3339 (serenity-rs#2665)
952e75f 
Fixes serenity-rs#2664
@jamesbt365 jamesbt365 mentioned this issue Jan 9, 2024
Closed
arqunis pushed a commit to arqunis/serenity that referenced this issue Jan 16, 2024
@Kerollmops @arqunis
Encode timestamps in RFC3339 (serenity-rs#2665)
b233932 
Fixes serenity-rs#2664
arqunis pushed a commit to arqunis/serenity that referenced this issue Jan 22, 2024
@Kerollmops @arqunis
Encode timestamps in RFC3339 (serenity-rs#2665)
226d853 
Fixes serenity-rs#2664
GnomedDev pushed a commit that referenced this issue Feb 9, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
c38603e 
Fixes #2664
arqunis pushed a commit to arqunis/serenity that referenced this issue Mar 1, 2024
@Kerollmops @arqunis
Encode timestamps in RFC3339 (serenity-rs#2665)
b23115e 
Fixes serenity-rs#2664
GnomedDev pushed a commit that referenced this issue Mar 10, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
72417c3 
Fixes #2664
GnomedDev pushed a commit that referenced this issue Mar 11, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
d6dc322 
Fixes #2664
GnomedDev pushed a commit that referenced this issue Mar 11, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
7d827ad 
Fixes #2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue Mar 13, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
11a948f 
Fixes serenity-rs#2664
GnomedDev pushed a commit that referenced this issue Mar 13, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
8875880 
Fixes #2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue Mar 19, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
c1209bf 
Fixes serenity-rs#2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue Mar 19, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
29634dd 
Fixes serenity-rs#2664
GnomedDev pushed a commit that referenced this issue Mar 21, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
010e224 
Fixes #2664
GnomedDev pushed a commit that referenced this issue Mar 25, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
1bb54b9 
Fixes #2664
GnomedDev pushed a commit that referenced this issue Mar 29, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
bb44458 
Fixes #2664
GnomedDev pushed a commit that referenced this issue Mar 31, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
abdb2d9 
Fixes #2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue Mar 31, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
0a33c6f 
Fixes serenity-rs#2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue Apr 1, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
962567c 
Fixes serenity-rs#2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue May 14, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
a8d39c7 
Fixes serenity-rs#2664
GnomedDev pushed a commit that referenced this issue May 14, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
8238f64 
Fixes #2664
GnomedDev pushed a commit that referenced this issue May 23, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
191bac3 
Fixes #2664
GnomedDev pushed a commit that referenced this issue May 28, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
02a9de7 
Fixes #2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue Jun 9, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
f20e8fc 
Fixes serenity-rs#2664
GnomedDev pushed a commit that referenced this issue Jun 22, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
308a210 
Fixes #2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue Jun 22, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
78968aa 
Fixes serenity-rs#2664
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this issue Jul 29, 2024
@Kerollmops @mkrasnitski
Encode timestamps in RFC3339 (serenity-rs#2665)
cd4f833 
Fixes serenity-rs#2664
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this issue Jul 30, 2024
@Kerollmops @mkrasnitski
Encode timestamps in RFC3339 (serenity-rs#2665)
cb3ecaf 
Fixes serenity-rs#2664
GnomedDev pushed a commit that referenced this issue Aug 16, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
71070f5 
Fixes #2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue Oct 7, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
86fd7a8 
Fixes serenity-rs#2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue Oct 20, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
7e7e753 
Fixes serenity-rs#2664
GnomedDev pushed a commit that referenced this issue Oct 20, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
d8e9478 
Fixes #2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue Nov 11, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
e339227 
Fixes serenity-rs#2664
GnomedDev pushed a commit that referenced this issue Nov 13, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (#2665)
ec34676 
Fixes #2664
GnomedDev pushed a commit to GnomedDev/serenity that referenced this issue Nov 15, 2024
@Kerollmops @GnomedDev
Encode timestamps in RFC3339 (serenity-rs#2665)
0700733 
Fixes serenity-rs#2664
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this issue Dec 8, 2024
@Kerollmops @mkrasnitski
Encode timestamps in RFC3339 (serenity-rs#2665)
6a4b6ce 
Fixes serenity-rs#2664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Encode timestamps in RFC3339 Kerollmops/serenity
2 participants
@Kerollmops @mkrasnitski