Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new routeOptions object. No more deprecation warnings #10

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

MattJustMatt
Copy link
Contributor

This fixes deprecation warnings because Fastify moved these into their own object, routeOptions.

@serdnam
Copy link
Owner

serdnam commented Sep 27, 2023

Hello! Thank you for making a PR!

I haven't had the time to look at this closely, but if I understand correctly, this routeOptions object was added in a recent minor version wasn't it? I would rather keep compatibility with the entire v4 line until v5 releases by either adding a fallback or just waiting it out.

@MattJustMatt
Copy link
Contributor Author

Thanks for taking a look! The routeOptions were added in v4.10 which was released in November 2022. I've tested this change back to then.

It's worth noting that this plugin already requires 4.5, so there's a precedent as well.

I'm happy to add backwards compatibility if needed but I'm guessing it should be ok. Anyone using latest fastify with the current version will have two extra log lines for every HTTP request, it's a lot!

Let me know what works best :)

@MattJustMatt
Copy link
Contributor Author

@serdnam what's the best route forward here?

@serdnam
Copy link
Owner

serdnam commented Oct 6, 2023

Let's go with adding backwards compatibility, add it to this PR and I'll get around to publishing a minor version this weekend.

@MattJustMatt
Copy link
Contributor Author

@serdnam apologies for the delay on this. I've updated the PR to include back compatibility

@serdnam serdnam merged commit 1f2d926 into serdnam:master Oct 15, 2023
@serdnam
Copy link
Owner

serdnam commented Oct 15, 2023

I have published v7.1.0, let me know if you have any issues. https://www.npmjs.com/package/@serdnam/fastify-sentry/v/7.1.0

Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants